change: remove two setuptools deprecations #4173

jjerphan · 2023-10-09T12:57:45Z

Issue #, if available:

None.

Description of changes:

Simple PR to understand the workflow.

Remove the following deprecations:

    /home/jjerphan/.local/share/mambaforge/envs/sdk/lib/python3.11/site-packages/setuptools/dist.py:498: SetuptoolsDeprecationWarning: Invalid dash-separated options
    !!

            ********************************************************************************
            Usage of dash-separated 'description-file' will not be supported in future
            versions. Please use the underscore name 'description_file' instead.

            This deprecation is overdue, please update your project and remove deprecated
            calls to avoid build errors in the future.

            See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
            ********************************************************************************

    !!
      opt = self.warn_dash_deprecation(opt, section)
    /home/jjerphan/.local/share/mambaforge/envs/sdk/lib/python3.11/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
    !!

            ********************************************************************************
            The license_file parameter is deprecated, use license_files instead.

            By 2023-Oct-30, you need to update your project and remove deprecated calls
            or your builds will no longer be supported.

            See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
            ********************************************************************************

    !!
      parsed = self.parsers.get(option_name, lambda x: x)(value)
    running develop

Testing done:

None.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-10-09T14:42:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 97de837
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T14:47:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 97de837
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T14:59:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 97de837
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T15:41:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 97de837
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-09T15:43:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 97de837
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Remove the following deprecations: ``` /home/jjerphan/.local/share/mambaforge/envs/sdk/lib/python3.11/site-packages/setuptools/dist.py:498: SetuptoolsDeprecationWarning: Invalid dash-separated options !! ******************************************************************************** Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead. This deprecation is overdue, please update your project and remove deprecated calls to avoid build errors in the future. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** !! opt = self.warn_dash_deprecation(opt, section) /home/jjerphan/.local/share/mambaforge/envs/sdk/lib/python3.11/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg` !! ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** !! parsed = self.parsers.get(option_name, lambda x: x)(value) running develop ``` Signed-off-by: Julien Jerphanion <[email protected]>

sagemaker-bot · 2023-10-10T00:44:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 98c2dc0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-10T00:51:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 98c2dc0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-10T01:27:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 98c2dc0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-10T01:37:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 98c2dc0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-10T01:42:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 98c2dc0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jjerphan · 2023-10-17T07:14:39Z

Hi @knikure

I think this PR is ready for review, I do not think that the failures on the CI are related.

What do you think?

sagemaker-bot · 2023-10-23T08:03:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5719166
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-23T08:09:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5719166
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-23T08:21:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5719166
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-23T08:32:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5719166
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-23T08:59:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5719166
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-10-24T07:39:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57fd632) 86.72% compared to head (4a3e007) 86.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4173      +/-   ##
==========================================
- Coverage   86.72%   86.59%   -0.13%     
==========================================
  Files        1197      380     -817     
  Lines      105633    34816   -70817     
==========================================
- Hits        91609    30150   -61459     
+ Misses      14024     4666    -9358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sagemaker-bot · 2023-10-24T08:27:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: afe043a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-24T08:46:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: afe043a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-24T08:48:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: afe043a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-24T09:28:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: afe043a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-24T10:21:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: afe043a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-02T17:06:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: aa0f46d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-02T17:21:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: aa0f46d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-02T17:31:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aa0f46d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-02T18:06:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: aa0f46d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-02T18:13:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa0f46d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-06T08:32:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: aa0f46d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-06T09:13:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: aa0f46d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-06T09:29:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa0f46d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jjerphan · 2023-11-06T10:09:11Z

Hi @goelakash,

The sporadic failures on the CI seem unrelated. Could you confirm?

How should we proceed?

sagemaker-bot · 2023-11-06T10:14:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: aa0f46d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-11-06T10:18:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aa0f46d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T09:49:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4a3e007
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T09:55:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4a3e007
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T09:59:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4a3e007
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T10:28:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4a3e007
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T10:47:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4a3e007
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jjerphan marked this pull request as ready for review October 9, 2023 13:40

jjerphan requested a review from a team as a code owner October 9, 2023 13:40

jjerphan requested review from knikure and removed request for a team October 9, 2023 13:40

goelakash force-pushed the change/remove-setuptools-deprecation branch from 97de837 to 98c2dc0 Compare October 9, 2023 23:48

martinRenou assigned jjerphan Oct 10, 2023

Merge branch 'master' into change/remove-setuptools-deprecation

5719166

Merge branch 'master' into change/remove-setuptools-deprecation

afe043a

Merge branch 'master' into change/remove-setuptools-deprecation

aa0f46d

Merge branch 'master' into change/remove-setuptools-deprecation

4a3e007

knikure self-assigned this Dec 5, 2023

knikure approved these changes Dec 5, 2023

View reviewed changes

knikure merged commit 72e5028 into aws:master Dec 5, 2023

jjerphan deleted the change/remove-setuptools-deprecation branch December 5, 2023 16:22

martinRenou mentioned this pull request Dec 12, 2023

Invalid dash-separated options for description-file #4301

Closed

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request May 8, 2024

change: remove two setuptools deprecations (aws#4173)

0c2ab8e

change: remove two setuptools deprecations #4173

change: remove two setuptools deprecations #4173

Conversation

jjerphan commented Oct 9, 2023 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 9, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 10, 2023

AWS CodeBuild CI Report

jjerphan commented Oct 17, 2023 • edited Loading

sagemaker-bot commented Oct 23, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 23, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 23, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 23, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 23, 2023

AWS CodeBuild CI Report

codecov-commenter commented Oct 24, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Oct 24, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 24, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 24, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 24, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Oct 24, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 6, 2023

AWS CodeBuild CI Report

jjerphan commented Nov 6, 2023

sagemaker-bot commented Nov 6, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Nov 6, 2023

AWS CodeBuild CI Report

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

mufaddal-rohawala commented Dec 5, 2023

jjerphan commented Oct 9, 2023 •

edited

Loading

jjerphan commented Oct 17, 2023 •

edited

Loading

codecov-commenter commented Oct 24, 2023 •

edited

Loading